Saithriftv2 check null sai apis by chrispsommers · Pull Request #1536 · opencomputeproject/SAI

chrispsommers · 2022-07-14T22:49:26Z

Fixes #1535. I modified the code-generator template to check for null SAI function pointers before calling, and throwing an exception with helpful message on the console.

The changed file of interest is actually just meta/templates/sai_rpc_server_functions.tt. There are more files in the change list because this PR includes changes from unmerged #1514 and #1533

Example console trace when calling switch_api->get_switch_attribute() which isn't implemented and has a null pointer. The process does not crash anymore.

Starting SAI RPC server on port 9092
NULL ptr: switch_api->get_switch_attribute

To understand how this works, the template inserts the following code (as an example) automatically:


    if (switch_api->get_switch_stats == (void *)0) {
        std::cerr << "NULL ptr: switch_api->get_switch_stats" << std::endl;
    
      sai_thrift_exception e;
      e.status = SAI_STATUS_NOT_IMPLEMENTED;
      throw e;
    }

right before making any API call such as:

    status = switch_api->get_switch_stats(switch_id, number_of_counters, sai_counter_ids, sai_counters);

…1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…file or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

… SAI extensions. Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…kage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

* Add VLAN and PortChannel test plan For vlan, it includes: 1. Vlan functionalities - Flooding - Forwarding - Trunk/Access - Tagging/Untagging(802.1Q) - VLAN interface (RIF/SVI) 2. SAI APIs operations - Vlan Counters - Vlan and member list operations For PortChannel, it includes: 1. Lag functionalities - Loadbalance 2. Lag SAI APIs - create/check/remove lag and lag member Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove cases not related to T0 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Add VLAN and Lag test plan and put topo config in seperated files Signed-off-by: richardyu <richardyu@contoso.com> * fix typo and more description more clear Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix lag test typo (opencomputeproject#29) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor vlan test plan and config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor lag test plan (opencomputeproject#33) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor pc and vlan test Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * Improve pc and vlan test Doc (opencomputeproject#35) * fix typo Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * remove some unnecessary comments Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * reformat and adjust the description of the tests Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * set hash algorithm (opencomputeproject#36) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refine lag test (opencomputeproject#37) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * correct vlan interface test (opencomputeproject#38) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * workaround for the sequence number issue in github and correct typo standardise the ip and mac naming in config add lag test for ingress port indifferenate in lag hash redesign the mac and ip namin convention and reformat Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * adjust the case numbers and vlan id Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

opencomputeproject#1499) * [SAI-PTF] Add SAI ptf test structure for T0 test Create SAI PTF test structure for T0 1. Create configuration structure for different components configu 2. Add FDB, PORT, switch, vlan configurations 3. Create Test structure base on PTF 4. Add T0 test case samples for FDB Test Done: Checked the ports functionality with port flooding Checked port forwarding base on FDB configurations Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add vlan config and vlan test sample case Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add dx010 config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…ct#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…rt added earlier for Route counters. (opencomputeproject#1497) Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. API sequence: sai_attribute_t counter_attr; attr.id = SAI_COUNTER_ATTR_TYPE; attr.value.s32 = SAI_COUNTER_TYPE_REGULAR; sai_object_id_t counter_id; sai_status_t rc = sai_counter_api->create_counter(&counter_id, g_switch_id, 1, &attr); sai_attribute_t ipmc_attr; attr.id = SAI_IPMC_ENTRY_ATTR_COUNTER_ID; attr.value.oid = counter_id; rc = sai_ipmc_api->set_ipmc_entry_attribute(route_entry, ipmc_attr); sai_stat_id_t stat_ids[] = { SAI_COUNTER_STAT_PACKETS, SAI_COUNTER_STAT_BYTES }; uint64_t stats[2]; rc = sai_counter_api->sai_get_counter_stats_ext(counter_id, 2, stat_ids, stats); Signed-off-by: rck-innovium <rck@innovium.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…oject#1484) saithriftv1 offers start_sai_thrift_rpc_server API to start the saithrift server and syncd is currently using that API https://github.com/Azure/sonic-sairedis/blob/master/syncd/syncd_main.cpp#L60 But this API is missing from the for saithriftv2. Made the relevant changes to provide a similar API for saithriftv2 library The start_sai_thrift_rpc_server API currently resides in saiserver.cpp which is not included in librpcserver.a and is not available for the users of the static library. Thus moved the function definition into sai_rpc_frontend.cpp for including it in the static library. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add vlan test case edit FilteringTest Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> edit vlan test case Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

* add more waiting time for test Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update fdb_configer.py increase the waiting time for fdb entries update Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove useless change Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

In order to set up the port on different platforms, need to read the data for port configuration when turning on the admin state This PR is a bug fix for adding the config_db into test resources folder. Test Done: Test within SONiC mgmt container Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

* add lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * enable lag config in test base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add remove_lag_member in lag_configer Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add sai_ipprefix() in utils Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * import LagConfiger in sai_test_base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add a simple lag test Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * fix a config error in lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag lb test based on scr port Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix Signed-off-by: zitingguo <736034564@qq.com> * set lag v4 hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag disable egress test case Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add IndifferenceIngressPortTest Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix set hash function Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * separate route configuration from lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * disable setting lag hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add virtual interface Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * Config default v4&v6 route Signed-off-by: zitingguo <736034564@qq.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…#1521) * add read config_db.json Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * tear down Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…roject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Attribute is introduced to configure IPFIX template reporting interval as per the RFC7011. https://datatracker.ietf.org/doc/html/rfc7011#section-8.4 Signed-off-by: Jai Kumar <jai.kumar@broadcom.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…-for-extensions

Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…hanges were not necessary if all extension headers are copied into /usr/include/sai at build time.

richardyu-ms · 2022-08-04T08:06:51Z

please resolve the merge conflict

* Add bulk create and remove for tunnel * Fix api order Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

* add fdb test Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add more comment, debugging and submit bug base on test result, add more method to clear the environment Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor code, add fdb test cases and restore steps Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * reformat code, add comment and remove unnessary import Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * reformat code Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * change the doc Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add comment for failed cases Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

* Build saithrift with python3.9 in bullseye Bullseye upgrade the python to python3.9 and other image, like buster still using python 2.7. To build with different python in different image, add a condition for copy differernt install file in different type of image. Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * change the release name to version number and reuse existing files Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: richardyu <richardyu@contoso.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

* Create SAI_PTF_user-guide.md SAI-PTF-V2 User Guide has details on how a user can build the SAI Thrift server and integrate it with their own specific libsai Signed-off-by: Reshma Sudarshan <reshma.sudarshan@intel.com> * Create readme.md Signed-off-by: Reshma Sudarshan <reshma.sudarshan@intel.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

opencomputeproject#1514) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…pencomputeproject#1546) * move the mac generate method to util Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * [SAI Test] Add Mac generate method and retry when turnning up port Add mac method for generating MAC address Retry when tunning up ports Test done: Test on DUT Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…eproject#1524) * [Test Plan] SAI test plan for tunnel QoS remapping (pcbb) Add sai test plan for tunnel QoS remapping (pcbb) Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix typo and correct gramma Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * specify the condition for ECN testing Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add dscp table with 63 values, add global config, add priority check attribute, add pfc check details, add test obj Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Change test description for global_dscp_remap Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * change the decription Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * reformat the doc Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * correct the description base on the comment in the PR Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add pcbb config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

* add lag cases Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * put locol cofig from router_configer to lag case Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * fix bug Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * edit pydoc Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…#1553) * config lag according to new config Signed-off-by: zitingguo <zitingguo@microsoft.com> Signed-off-by: zitingguo-ms <zitingguo@microsoft.com> * Add port1 route interface into default route config Signed-off-by: zitingguo-ms <zitingguo@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

This change includes support for reading the following PHY layer diagnostics in SAI - Per PMD Lane Rx Signal Detect Per PMD Lane Rx Lock Status (aka CDR status) PCS Rx Link Status Per FEC Lane Alignment Marker Lock Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

* [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add static_cast<> to sairpcgen templates to avoid type mismatches for SAI extensions. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add new env variable SAIRPC_EXTRA_LIBS which gets passed to final linkage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental to include path. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental headers to CPPFLAGS passed to ctypesgen. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add VLAN and PortChannel test plan (opencomputeproject#1480) * Add VLAN and PortChannel test plan For vlan, it includes: 1. Vlan functionalities - Flooding - Forwarding - Trunk/Access - Tagging/Untagging(802.1Q) - VLAN interface (RIF/SVI) 2. SAI APIs operations - Vlan Counters - Vlan and member list operations For PortChannel, it includes: 1. Lag functionalities - Loadbalance 2. Lag SAI APIs - create/check/remove lag and lag member Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove cases not related to T0 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Add VLAN and Lag test plan and put topo config in seperated files Signed-off-by: richardyu <richardyu@contoso.com> * fix typo and more description more clear Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix lag test typo (opencomputeproject#29) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor vlan test plan and config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor lag test plan (opencomputeproject#33) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor pc and vlan test Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * Improve pc and vlan test Doc (opencomputeproject#35) * fix typo Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * remove some unnecessary comments Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * reformat and adjust the description of the tests Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * set hash algorithm (opencomputeproject#36) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refine lag test (opencomputeproject#37) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * correct vlan interface test (opencomputeproject#38) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * workaround for the sequence number issue in github and correct typo standardise the ip and mac naming in config add lag test for ingress port indifferenate in lag hash redesign the mac and ip namin convention and reformat Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * adjust the case numbers and vlan id Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [SAI-PTF] SAI PTF test structure for T0 test and VLAN,FDB sample cases (opencomputeproject#1499) * [SAI-PTF] Add SAI ptf test structure for T0 test Create SAI PTF test structure for T0 1. Create configuration structure for different components configu 2. Add FDB, PORT, switch, vlan configurations 3. Create Test structure base on PTF 4. Add T0 test case samples for FDB Test Done: Checked the ports functionality with port flooding Checked port forwarding base on FDB configurations Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add vlan config and vlan test sample case Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add dx010 config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [meta] Add sai_status_t to ancestry check (opencomputeproject#1501) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * reset sleep time during turning up ports (opencomputeproject#1502) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [saineighbor] Bulk API support for Neighbor entries (opencomputeproject#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan testcases from Group6 to Group10 (opencomputeproject#1506) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. (opencomputeproject#1497) Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. API sequence: sai_attribute_t counter_attr; attr.id = SAI_COUNTER_ATTR_TYPE; attr.value.s32 = SAI_COUNTER_TYPE_REGULAR; sai_object_id_t counter_id; sai_status_t rc = sai_counter_api->create_counter(&counter_id, g_switch_id, 1, &attr); sai_attribute_t ipmc_attr; attr.id = SAI_IPMC_ENTRY_ATTR_COUNTER_ID; attr.value.oid = counter_id; rc = sai_ipmc_api->set_ipmc_entry_attribute(route_entry, ipmc_attr); sai_stat_id_t stat_ids[] = { SAI_COUNTER_STAT_PACKETS, SAI_COUNTER_STAT_BYTES }; uint64_t stats[2]; rc = sai_counter_api->sai_get_counter_stats_ext(counter_id, 2, stat_ids, stats); Signed-off-by: rck-innovium <rck@innovium.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add thr missing API into saithriftv2 missing for syncd (opencomputeproject#1484) saithriftv1 offers start_sai_thrift_rpc_server API to start the saithrift server and syncd is currently using that API https://github.com/Azure/sonic-sairedis/blob/master/syncd/syncd_main.cpp#L60 But this API is missing from the for saithriftv2. Made the relevant changes to provide a similar API for saithriftv2 library The start_sai_thrift_rpc_server API currently resides in saiserver.cpp which is not included in librpcserver.a and is not available for the users of the static library. Thus moved the function definition into sai_rpc_frontend.cpp for including it in the static library. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan test case (opencomputeproject#1510) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add vlan test case edit FilteringTest Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> edit vlan test case Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add more waiting time for test (opencomputeproject#1511) * add more waiting time for test Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update fdb_configer.py increase the waiting time for fdb entries update Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove useless change Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add read config_db.json (opencomputeproject#1519) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [Fix]Add necessary test data file for sai test (opencomputeproject#1520) In order to set up the port on different platforms, need to read the data for port configuration when turning on the admin state This PR is a bug fix for adding the config_db into test resources folder. Test Done: Test within SONiC mgmt container Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Zitingguo/add lag test (opencomputeproject#1522) * add lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * enable lag config in test base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add remove_lag_member in lag_configer Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add sai_ipprefix() in utils Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * import LagConfiger in sai_test_base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add a simple lag test Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * fix a config error in lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag lb test based on scr port Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix Signed-off-by: zitingguo <736034564@qq.com> * set lag v4 hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag disable egress test case Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add IndifferenceIngressPortTest Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix set hash function Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * separate route configuration from lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * disable setting lag hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add virtual interface Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * Config default v4&v6 route Signed-off-by: zitingguo <736034564@qq.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add teardown for testing multiple cases at a time (opencomputeproject#1521) * add read config_db.json Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * tear down Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Added missing dependencies required to run gensairpc.pl (opencomputeproject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Update saitam.h (opencomputeproject#1496) Attribute is introduced to configure IPFIX template reporting interval as per the RFC7011. https://datatracker.ietf.org/doc/html/rfc7011#section-8.4 Signed-off-by: Jai Kumar <jai.kumar@broadcom.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Pass SAIRPC_EXTRA_LIBS flag in Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Removed changes to include paths for SAI extension headers; as it turns out these changes were not required as originally reported in opencomputeproject#1531. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Richard.Yu <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

…eproject#1552) In Syncd starting process, it will try to start the switch and assign the gSwtichId to the sai implementation. In the syncd rpc container, in order to get the swtich id after syncd initalization, we need to get and check the switch id. Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

chrispsommers · 2022-08-04T23:12:46Z

Superceded by #1558, this PR had rebasing artifacts and was not clean.

kcudnik and others added 25 commits July 11, 2022 13:22

[doc] Add SAI metadata introduction presentation (opencomputeproject#…

c5bb56e

…1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Make…

5212f65

…file or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Add static_cast<> to sairpcgen templates to avoid type mismatches for…

49d03ae

… SAI extensions. Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Add new env variable SAIRPC_EXTRA_LIBS which gets passed to final lin…

170d3c5

…kage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Add experimental to include path.

9c6a99e

Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Add experimental headers to CPPFLAGS passed to ctypesgen.

5170c04

Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

[meta] Add sai_status_t to ancestry check (opencomputeproject#1501)

7159969

Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

reset sleep time during turning up ports (opencomputeproject#1502)

a103b06

Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

[saineighbor] Bulk API support for Neighbor entries (opencomputeproje…

45f932d

…ct#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

add vlan testcases from Group6 to Group10 (opencomputeproject#1506)

7adb04f

Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Added missing dependencies required to run gensairpc.pl (opencomputep…

905da92

…roject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

Merge remote-tracking branch 'upstream/master' into saithriftv2-fixes…

da95162

…-for-extensions

Pass SAIRPC_EXTRA_LIBS flag in Makefile

662650c

Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

gensairpc.pl: perform check for null func ptr before calling SAI api.

38d15a8

Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

chrispsommers force-pushed the saithriftv2-check-null-sai-apis branch from da35b21 to 38d15a8 Compare July 18, 2022 16:08

Remove changes for SAI extension include paths, as it turns out the c…

3feb459

…hanges were not necessary if all extension headers are copied into /usr/include/sai at build time.

kcudnik and others added 2 commits August 4, 2022 14:23

Add bulk create and remove for tunnel (opencomputeproject#1462)

4489f42

* Add bulk create and remove for tunnel * Fix api order Signed-off-by: Chris Sommers <chrispsommers@gmail.com>

richardyu-ms and others added 10 commits August 4, 2022 14:23

chrispsommers mentioned this pull request Aug 4, 2022

Check for NULL APIs returned by sai_api_query() and handle gracefully instead of crashing. #1558

Merged

chrispsommers closed this Aug 4, 2022

chrispsommers mentioned this pull request Aug 4, 2022

[SAI-PTF] Enable saiserverv2 with syncd-rpc and fix saithriftv2 build (#1552) (#1533) (#1514) (#1492) (#1558) #1557

Merged

chrispsommers deleted the saithriftv2-check-null-sai-apis branch August 7, 2022 20:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Saithriftv2 check null sai apis#1536

Saithriftv2 check null sai apis#1536
chrispsommers wants to merge 38 commits intoopencomputeproject:masterfrom
chrispsommers:saithriftv2-check-null-sai-apis

chrispsommers commented Jul 14, 2022

Uh oh!

richardyu-ms commented Aug 4, 2022

Uh oh!

chrispsommers commented Aug 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

chrispsommers commented Jul 14, 2022

Uh oh!

richardyu-ms commented Aug 4, 2022

Uh oh!

chrispsommers commented Aug 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants